Mike Percy has posted comments on this change.

Change subject: client_failover-itest: fix flakiness with opid mismatches
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2479/1/src/kudu/integration-tests/client_failover-itest.cc
File src/kudu/integration-tests/client_failover-itest.cc:

Line 160:   
ASSERT_OK(WaitUntilCommittedOpIdIndexIs(workload.batches_completed() + 3, 
leader, tablet_id,
The +3 here accounts for the NO_OP written by the leader after it's elected. So 
I'm not sure why WaitUntilLeader() would help here.


Line 187:   ASSERT_OK(itest::WaitUntilLeader(leader, tablet_id, kTimeout));
Same


-- 
To view, visit http://gerrit.cloudera.org:8080/2479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3df1b3f5b0903f069a5e7ae3ba2a64c1c52a427
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to