Todd Lipcon has submitted this change and it was merged. Change subject: random: re-implement Random::Normal using std::normal_distribution ......................................................................
random: re-implement Random::Normal using std::normal_distribution Since we were only using this one function from the WebRTC source code, it was easier to just use std::normal_distribution than worry about the proper way to attribute WebRTC (BSD license). Tested with the existing unit test, and also modified it to dump a few thousand values to a text file. I verified the resulting distribution in R: > sd(d$V1) [1] 0.01002238 > mean(d$V1) [1] 4.999974 (which is close enough given the sample size) Change-Id: Id2101d1375618a87b370162c067f9bbf2035cf33 Reviewed-on: http://gerrit.cloudera.org:8080/2481 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <[email protected]> --- M LICENSE.txt M src/kudu/util/random.h 2 files changed, 30 insertions(+), 46 deletions(-) Approvals: Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2101d1375618a87b370162c067f9bbf2035cf33 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
