Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2478
to look at the new patch set (#2).
Change subject: Move OverwriteWithPattern to new file optimized at -O3
......................................................................
Move OverwriteWithPattern to new file optimized at -O3
This function ends up taking a fair amount of CPU in debug builds. We already
optimized it at -O3 for gcc, but clang doesn't support per-function
optimization. This commit just moves it to a new file and applies -O3 to that
file, so that clang builds also get an optimized implementation.
Hopefully this will improve flakiness of some tests that show up in ASAN/TSAN
builds due to very slow performance. This improved
'ts_recovery-itest --gtest_filter=\*969\*' from ~33s to ~25s on my laptop
in an ASAN build.
Change-Id: I1f18e6de3d5f5ab21b490ea4213c86b4d25706ba
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/common/columnblock.h
M src/kudu/common/partial_row.cc
M src/kudu/common/predicate-test.cc
M src/kudu/common/rowblock.h
M src/kudu/tablet/cbtree-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/memory/memory.cc
M src/kudu/util/memory/memory.h
A src/kudu/util/memory/overwrite.cc
A src/kudu/util/memory/overwrite.h
12 files changed, 91 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/2478/2
--
To view, visit http://gerrit.cloudera.org:8080/2478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f18e6de3d5f5ab21b490ea4213c86b4d25706ba
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
