Todd Lipcon has posted comments on this change. Change subject: Fix UniformRandomNumberGenerator concept impl ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2489/1/src/kudu/util/random.h File src/kudu/util/random.h: Line 235: constexpr static uint32_t max() { return UINT32_MAX; } this isn't quite right -- Next32's MSB is always 0 -- To view, visit http://gerrit.cloudera.org:8080/2489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1c8766fee491fc3116a0ff28a76d1a41eeaadc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
