Todd Lipcon has submitted this change and it was merged. Change subject: rpc: make generated Proxies subclass Proxy ......................................................................
rpc: make generated Proxies subclass Proxy Rather than composition, inheritance actually makes sense, so that we don't have to generate pass-through methods for everything we want to expose in the Proxy. Change-Id: If910b91b1ffcb48641d631ede728b6adbaecf9a9 Reviewed-on: http://gerrit.cloudera.org:8080/2511 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/rpc/protoc-gen-krpc.cc 1 file changed, 4 insertions(+), 20 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If910b91b1ffcb48641d631ede728b6adbaecf9a9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
