Todd Lipcon has posted comments on this change.

Change subject: thirdparty: llvm build should clear old artifacts
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2539/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 78:   # The LLVM build can fail if a different version is already installed
> Would it be too drastic to blow away everything under $PREFIX (and all vari
I suppose it's reasonable, except that it would really annoy me because I often 
start building thirdparty and then ^C it while it's still in the process of 
building cmake, because I know that whatever changed in thirdparty isn't really 
important (eg I'm trying to bisect across an irrelevant thirdparty change or 
something). So, I'd prefer not, at least in interactive builds. (maybe a flag 
that we can use on jenkins, where these types of failures are most annoying?)


-- 
To view, visit http://gerrit.cloudera.org:8080/2539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida093005e2d68d0413b1244c53c4d94208590944
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to