Dan Burkert has posted comments on this change. Change subject: rpc: call-level feature flags ......................................................................
Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/2239/12/src/kudu/util/scoped_cleanup.h File src/kudu/util/scoped_cleanup.h: Line 27: ScopedCleanup(F f) : f_(f) {} > should this use std::forward(f) so that f_ will get moved if possible? no, but it should be using std::move. -- To view, visit http://gerrit.cloudera.org:8080/2239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46e46bcf80b93fc6cce50f37dd71a6e6539047f8 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
