David Ribeiro Alves has posted comments on this change. Change subject: design-docs: multi-master for 1.0 release ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/2527/1/docs/design-docs/multi-master-1.0.md File docs/design-docs/multi-master-1.0.md: Line 120: f > This issue is perhaps the most complicated of the ones listed here, and I'm It's OK if you don't change 1353, but it would be good to have a jira to track it, can you create it? Line 130: ### > Maybe, maybe not. For example, I can see us shipping 1.0 without fixing KUD then it's weird cuz this doc is called multi-master-1.0. Either make no reference to target release version, or maybe split the features into some target and strech goals? Line 200: 2. All destructive actions taken by a tserver must be "fenced". That is, the > What does broadening the definition buy us? Are we splitting semantic hairs creating a tablet? splitting a tablet in the future.... Line 204: current master term > I think someone (Mike, perhaps?) suggested that the term would be sufficien term helps with messages from different masters, index helps with out-of-order messages from the same master, which likely are possible with timeouts Line 206: Ensure that the leader master replicates via Raft before triggering an : action. It doesn't matter what is replicated (a no-op would suffice); : a successful replication asserts that this master is still the leader. > To be fair, I think this is more complicated than option #1 at the moment, I'm ok if we don't flesh this out right now. think we need to ponder this further if we choose this route Line 212: partially replicated : operations > Sorry for the miscommunication. I'll do some RPC size measurement and updat post your findings here? -- To view, visit http://gerrit.cloudera.org:8080/2527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad76012977a45370b72a04d608371cecf90442ef Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
