Dan Burkert has posted comments on this change. Change subject: [java-client] add support for RPC and application feature flags ......................................................................
Patch Set 1: I've done tests by hand using a follow up commit that adds the new ColumnPredicate API to Java, and consequently uses an application feature flag. I tested that by running the existing tests (which use predicates and thus an application feature flag) against builds of the C++ server with and without RPC feature flags, and it worked as expected. Adding unit tests is hard, because it's about three layers into the internals, and none of it is exposed or unit tested (AsyncKuduClient -> TableClient -> SecureRpcHelper). -- To view, visit http://gerrit.cloudera.org:8080/2566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a0af956b7f4c949ce79e06c877db5f4220c9a5f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
