Adar Dembo has posted comments on this change. Change subject: master: don't expose intermediate CreateTable() state to consumers ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2577/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 880: } > can we refactor the above 10 lines into a utility function? Looks like it's Sure, will do. http://gerrit.cloudera.org:8080/#/c/2577/1/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: Line 521: ASSERT_OK(CreateTable(kTableName, kTableSchema)); > if for some reason the CreateTable timed out, then the thread would keep ru Or I could change it to EXPECT_OK(), right? I'll do that; let me know if it doesn't behave the way I expect. -- To view, visit http://gerrit.cloudera.org:8080/2577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05ab48d5a9dd328b4a74f5dc35c710cd1c01f3cd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
