Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-1377: Ignore corrupted trailing records on LBM metadata ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2595/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 443: return Status::OK(); As I mentioned in Slack, the issue with this approach is that it allows recovery from the very first corrupt record, _even if that corrupt record is followed by good ones_. We need to distinguish between the two cases, allowing recovery in the first case but preventing it in the latter, much like the WAL. This distinction is described in KUDU-668. -- To view, visit http://gerrit.cloudera.org:8080/2595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b88ba051b390b6a2587eecdd205c478f1edccb4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
