Todd Lipcon has posted comments on this change. Change subject: Upgrade to LLVM 3.8.0 ......................................................................
Patch Set 1: I had a patch ready against the 3.8rc2 build a few weeks ago. I needed this hunk for it to build properly; diff --git a/src/kudu/gutil/dynamic_annotations.h b/src/kudu/gutil/dynamic_annotations.h index 4d69a3f..ce68d89 100644 --- a/src/kudu/gutil/dynamic_annotations.h +++ b/src/kudu/gutil/dynamic_annotations.h @@ -575,6 +575,8 @@ double ValgrindSlowdown(void); /* AddressSanitizer annotations from LLVM asan_interface.h */ + +#if defined(__SANITIZE_ADDRESS__) || defined(ADDRESS_SANITIZER) // Marks memory region [addr, addr+size) as unaddressable. // This memory must be previously allocated by the user program. Accessing // addresses in this region from instrumented code is forbidden until @@ -594,7 +596,6 @@ void __asan_poison_memory_region(void const volatile *addr, size_t size); void __asan_unpoison_memory_region(void const volatile *addr, size_t size); // User code should use macros instead of functions. -#if defined(__SANITIZE_ADDRESS__) || defined(ADDRESS_SANITIZER) #define ASAN_POISON_MEMORY_REGION(addr, size) \ __asan_poison_memory_region((addr), (size)) #define ASAN_UNPOISON_MEMORY_REGION(addr, size) \ -- To view, visit http://gerrit.cloudera.org:8080/2599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbd55969aff9b7120d49288e6c87e1885b356d00 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
