Mike Percy has posted comments on this change.
Change subject: Add Kudu Flume sink.
......................................................................
Patch Set 1:
(1 comment)
Mind adding an integration test?
Here is a diff for a skeleton of a test that can use the Kudu minicluster to
run against a real instance. Check out TestAsyncKuduClient for examples.
diff --git a/java/kudu-flume-sink/pom.xml b/java/kudu-flume-sink/pom.xml
index 1690529..f5c700d 100644
--- a/java/kudu-flume-sink/pom.xml
+++ b/java/kudu-flume-sink/pom.xml
@@ -48,6 +48,28 @@
<artifactId>kudu-client</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.kududb</groupId>
+ <artifactId>kudu-client</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.kududb</groupId>
+ <artifactId>kudu-client</artifactId>
+ <version>${project.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>${junit.version}</version>
+ <scope>test</scope>
+ </dependency>
+
</dependencies>
</project>
diff --git
a/java/kudu-flume-sink/src/test/java/org/kududb/flume/sink/KuduSinkTest.java
b/java/kudu-flume-sink/src/test/java/org/kududb/flume/sink/KuduSinkTest.java
new file mode 100644
index 0000000..4c32b35
--- /dev/null
+++ b/java/kudu-flume-sink/src/test/java/org/kududb/flume/sink/KuduSinkTest.java
@@ -0,0 +1,12 @@
+package org.kududb.flume.sink;
+
+import org.junit.Test;
+import org.kududb.client.BaseKuduTest;
+
+public class KuduSinkTest extends BaseKuduTest {
+
+ @Test
+ public void testKuduSink() {
+ }
+
+}
http://gerrit.cloudera.org:8080/#/c/2600/1/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java
File java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java:
Line 196: response
I think responses will be null if we get DeferredGroupException
--
To view, visit http://gerrit.cloudera.org:8080/2600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53e02580908ba2468b216543719ebe5011a267c3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ara Ebrahimi <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-HasComments: Yes
