Dan Burkert has posted comments on this change. Change subject: KUDU-1312 - design doc for scan token API ......................................................................
Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/2443/3//COMMIT_MSG Commit Message: Line 7: Initial scan tokens design doc > mind throwing the JIRA number in here? Done http://gerrit.cloudera.org:8080/#/c/2443/3/docs/design-docs/scan-tokens.md File docs/design-docs/scan-tokens.md: Line 20: split Kudu tables into logical sections, so that computation can be distributed > physical sections, not logical, right? Done Line 36: defined serialization format so that tokens may be serialized and deserialized > well defined (but opaque to the caller) Done Line 43: location hint, or a hint for every replica? > I think multiple hints, but with a preference for the current leader? proba I've changed it to just give back an instance of a tablet server, which already handle this issue. Line 47: 2) How should scan tokens handle going stale WRT tablet location changes and > perhaps we can provide an API on a scanner like 'IsLocal()'? that's also us I've updated the proposal to reuse the existing located tablet APIs. I think this will be simpler, and combined with the ReplicaSelection API should be good enough for MR/Spark/Impala. Line 54: point, but it will be an important consideration once that feature lands. > I vote for the partition key range, since that will support splits at some Done Line 60: client could. > yes I think this is a very useful API -- right now we ask people to split i Done -- To view, visit http://gerrit.cloudera.org:8080/2443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id208cecababf15e1671a01a219d4599adfcd4163 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
