Adar Dembo has posted comments on this change. Change subject: [java client] Allow ignore duplicate rows in auto flush sync mode ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2607/1/java/kudu-client/src/test/java/org/kududb/client/TestKuduSession.java File java/kudu-client/src/test/java/org/kududb/client/TestKuduSession.java: Line 70: session.setFlushMode(SessionConfiguration.FlushMode.MANUAL_FLUSH); The test would be more clear if you restructured it around a FlushMode loop (i.e. "for each flush mode, do..."). The only catch is you'd need to special-case flush handling for each mode. For MANUAL_FLUSH you'd need to add an explicit flush() call, and for AUTO_FLUSH_BACKGROUND you'd need to wait for the outstanding operations to complete (is that also via flush()? Can't remember). -- To view, visit http://gerrit.cloudera.org:8080/2607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I671dd1bf537c2f5e6aa757883b350768081eb035 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin Chang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
