Dan Burkert has posted comments on this change. Change subject: [java-client] implement ColumnPredicate API ......................................................................
Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/2591/2/java/kudu-client/src/main/java/org/kududb/client/AbstractKuduScannerBuilder.java File java/kudu-client/src/main/java/org/kududb/client/AbstractKuduScannerBuilder.java: Line 38: final Map<String, KuduPredicate> predicates = new HashMap<>(); > Just reading this line, it's not evident that this is keyed by column name. Done Line 74: addPredicate > Use the proper javadoc syntax Done http://gerrit.cloudera.org:8080/#/c/2591/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java: Line 330: if (predicate.getType() == KuduPredicate.PredicateType.NONE) { > I really don't understand this part. I've added a comment, let me know if it's still confusing. Line 338: this.hasMore = false; > This looks like scanFinished, anyway to refactor? There is some stuff going on in scanFinished which makes it inappropriate to call, and I figured since it's two simple lines it wouldn't be worth it to try and abstract. http://gerrit.cloudera.org:8080/#/c/2591/2/java/kudu-client/src/main/java/org/kududb/client/ColumnRangePredicate.java File java/kudu-client/src/main/java/org/kududb/client/ColumnRangePredicate.java: Line 67: /** > Cleanup the double javadoc Done http://gerrit.cloudera.org:8080/#/c/2591/2/java/kudu-client/src/main/java/org/kududb/client/KuduPredicate.java File java/kudu-client/src/main/java/org/kududb/client/KuduPredicate.java: Line 76: * @param op the comparison operation, must be ComparisonType.EQUALITY > Should we just not have that parameter at all? I wrote it this way to keep it consistent with the rest of the API (and the c++ api). Definitely an option to create a static factory function like booleanEquality(ColumnSchema, boolean), though. http://gerrit.cloudera.org:8080/#/c/2591/2/java/kudu-client/src/test/java/org/kududb/client/TestKuduClient.java File java/kudu-client/src/test/java/org/kududb/client/TestKuduClient.java: Line 268: public void testScanWithPredicates() throws Exception { > Is this testing the short circuit case? Yes, the final case is testing short circuit. I've added a comment, but I can split it into a standalone test if you prefer. -- To view, visit http://gerrit.cloudera.org:8080/2591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdca28139a2f4f15633cfd872e372429bad831cd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
