David Ribeiro Alves has posted comments on this change. Change subject: KUDU-495 (part 1): new sys_catalog writing API ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2648/2/src/kudu/master/sys_catalog.h File src/kudu/master/sys_catalog.h: Line 96: // Perform a series of table/tablet actions in one WriteTransaction. > Actually, I structured it this way on purpose. It's like this: oh, I see. I does make sense in that context though it's nothing I've seen anywhere else. Since the next person is likely to make the same mistake I made, can you think of a way to make your intent more explicit? If nothing obvious comes to mind I'm ok with the current form (and had +2d anyway) -- To view, visit http://gerrit.cloudera.org:8080/2648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f5e5ecbff33435c964ced2e421566c41c387e9e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
