Dan Burkert has posted comments on this change. Change subject: Add internal IS NOT NULL predicate type ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2671/3/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: Line 291: CHECK(block.is_nullable()); > why not just return if the type is not nullable? what if a user specifies a Done Line 292: for (size_t i = 0; i < block.nrows(); i++) { > can you add a TODO to do this more efficiently by just using bitwise ops on Done -- To view, visit http://gerrit.cloudera.org:8080/2671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf29b1f274df2ef5c5ac7a7a17cc06dfd59e191 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
