Dan Burkert has posted comments on this change. Change subject: Fix OSX build breakage with clang versions newer than 700 ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2692/1/cmake_modules/CompilerInfo.cmake File cmake_modules/CompilerInfo.cmake: Line 36: 0* Can you change this to ".*clang-7". I think that will be a little more future proof, that being said it's hard to say with completely made up version numbers. -- To view, visit http://gerrit.cloudera.org:8080/2692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c54ae7a7e2fe12b4d9d305f4dcd5343ffa6ba86 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
