Dan Burkert has posted comments on this change. Change subject: [c++ client] add comprehensive scan predicate tests ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2677/2//COMMIT_MSG Commit Message: Line 11: There is unfortunately a lot of code duplication between the test cases, but > How about at least sharing the common code to open the table, create a sess Done http://gerrit.cloudera.org:8080/#/c/2677/2/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: Line 29: #include "kudu/gutil/strings/escaping.h" > Nit: should precede substitute. Done -- To view, visit http://gerrit.cloudera.org:8080/2677 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4a4c05a41a1e7984f330fe6ff912f3f9924c3a7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
