Adar Dembo has posted comments on this change. Change subject: KUDU-1380. Fix retry for BUSY on non-FT scans ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2654/4/src/kudu/client/client.cc File src/kudu/client/client.cc: Line 1165: bool allow_time_for_failover = data_->is_fault_tolerant_; : ScanRpcStatus result = data_->SendScanRpc(batch_deadline, allow_time_for_failover); > really? I like it this way because it provides a nice name for the boolean I don't feel strongly about it. I like brevity but I can see your point too. -- To view, visit http://gerrit.cloudera.org:8080/2654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I048d3aa2a163143d1637ae87281ed91f0fc5ac65 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
