Mike Percy has posted comments on this change. Change subject: Add javadoc for Kudu Flume sink ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2713/1/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java File java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java: Line 55: * <tr><td>type</td><td></td><td>Yes</td><td>Component name. Must be <tt>org.kududb.flume.sink.KuduSink</tt></td></tr> > Curious about this. It's required but it has to be a specific value and the Yeah it's a Flume thing. We're just specifying the sink type. I'm following the way it's written in the Flume User Guide, so anyone who has used Flume before would immediately understand, I think. Line 62: * <tr><td>producer.*</td><td><tt></tt></td><td></td><td>Configuration properties to pass to the event producer.</td></tr> > Doesn't indicate if required? Clarified this. -- To view, visit http://gerrit.cloudera.org:8080/2713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cf5d540f1883528f46806089f0abf5d8ad20faa Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
