Adar Dembo has posted comments on this change. Change subject: KUDU-1396. Fix index building when an individual value overflows block ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/2725/2/src/kudu/cfile/cfile-test-base.h File src/kudu/cfile/cfile-test-base.h: Line 246: std::vector<std::string> data_buffers_; Just curious: the motivation for this change was so you could store strings larger than 15 bytes? http://gerrit.cloudera.org:8080/#/c/2725/2/src/kudu/cfile/cfile-test.cc File src/kudu/cfile/cfile-test.cc: Line 504: ASSERT_EQ(StringPrintf(str_format, 5000), s.ToString()); May be clearer if, before each StringPrintf (or loop that does the equivalent), you add a comment describing the string being created. Here it'd be "hello 05000", in the first loop it'd be "hello 00000.5" to "hello 10000.5", etc. Line 524: arena.Reset(); What happens if the arena isn't reset, as before? Line 603: TestReadWriteStrings(PLAIN_ENCODING, "%066000d"); I know I'm missing something obvious, but what makes this particular format generate really long strings? -- To view, visit http://gerrit.cloudera.org:8080/2725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic27485bc0b2151e7c182c36e7ad6258dc549517b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
