Jean-Daniel Cryans has posted comments on this change. Change subject: WIP: Add a design doc for rpc retry/failover semantics ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2642/1/docs/design-docs/rpc-retry-and-failover.md File docs/design-docs/rpc-retry-and-failover.md: Line 158: Wal garbage collections should be set higher That's the most worrying part to me, especially since we still don't identify flushed rows when replaying the logs. Also, could we entertain a notion of TTL? Say a tablet stops being busy, we'd still keeps some logs around, so I think we wouldn't run WAL GC. This means that we wouldn't clear the CompletionRecordStore of RPCs that have been completed for a while. -- To view, visit http://gerrit.cloudera.org:8080/2642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc2aa40486153b39724e1c9bd09c626b829274c6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
