Adar Dembo has posted comments on this change. Change subject: Add a test for the code cache ......................................................................
Patch Set 1: (1 comment) Looks fine, but what's the motivation? Did you use it to find a bug? http://gerrit.cloudera.org:8080/#/c/2618/1/src/kudu/codegen/codegen-test.cc File src/kudu/codegen/codegen-test.cc: Line 392: } while (std::next_permutation(perm.begin(), perm.end())); Nit: indentation. -- To view, visit http://gerrit.cloudera.org:8080/2618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b8f450c5f81f2b21f90e5f1059ca59550ca7fb6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
