Todd Lipcon has posted comments on this change. Change subject: master: don't expose any CreateTable() state too early ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/2714/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 765: // d. Create the in-memory representation of the new table and its tablets. I think it's worth noting here that you are creating the representation but _not_ linking it into any global catalogmanager state. Line 778: TRACE("Inserted new table and tablet info into CatalogManager maps"); this trace is no longer correct, right? http://gerrit.cloudera.org:8080/#/c/2714/1/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: Line 845: // with ServiceUnavailable status. I'm not sold on ServiceUnavailable as the code here -- usually this tells the client it's something worth retrying later. Maybe Status::Incomplete? Or Status::Uninitialized? Line 855: TEST_F(MasterTest, TestConcurrentCreateOfSameTable) { point to the JIRA with a comment here Line 862: // Kick off a thread that calls GetTableSchema() in a loop. this doesn't seem right -- To view, visit http://gerrit.cloudera.org:8080/2714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9e11037e7f8b4c34db5e0f2b5be00f806532365 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
