Adar Dembo has posted comments on this change. Change subject: KUDU-777. Fix potential use-after-free after major delta compaction ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/2731/1/src/kudu/tablet/rowset.h File src/kudu/tablet/rowset.h: Line 106: virtual Status GetBounds(std::string *min_encoded_key, Nit: since you're already making changes here, could you put the * next to the type? In other files too, if needed. http://gerrit.cloudera.org:8080/#/c/2731/1/src/kudu/tablet/rowset_info.cc File src/kudu/tablet/rowset_info.cc: Line 50: // Less-than comparison by minimum key (both by actual key slice and cdf) Nit: if we're being pedantic (and I know I am!), it's not actually a key "slice" anymore. Below too. Line 284: ret.append(" [").append(Slice(min_key_).ToDebugString()); Why do you need to convert these to Slices? Aren't they already strings? -- To view, visit http://gerrit.cloudera.org:8080/2731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife1adaa3125642fc96364be69f42989800241256 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
