Todd Lipcon has posted comments on this change. Change subject: WIP: Update term when election failed due to higher term ......................................................................
Patch Set 1: (1 comment) Agreed a test would be good -- particularly one which tries to reproduce a somewhat realistic scenario (eg asymmetric configuration membership, like Binglin hit on his cluster). http://gerrit.cloudera.org:8080/#/c/2733/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1802: LOG_WITH_PREFIX(INFO) << "Leader election lost for term " << result.election_term shouldn't this be LOG_WITH_PREFIX_UNLOCKED? -- To view, visit http://gerrit.cloudera.org:8080/2733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5062105202241d7126980627befca8a453593dc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
