Jean-Daniel Cryans has posted comments on this change.

Change subject: Non-covering Range Partitions design doc
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2772/1/docs/design-docs/non-covering-range-partitions.md
File docs/design-docs/non-covering-range-partitions.md:

Line 18: it is impossible to supply an upper or lower bound, or create a
       : table with gaps in the partition space.
You could also say that both ends of the specified range extend to eternity.


Line 37: This feature is often called `LIST`
       : partitioning in other analytic databases.
Maybe add a reference?


Line 104: If
        : the client limits the scan to a non-existent range partition through 
either
        : predicates or primary key bounds no results will be returned at all.
I wonder, should we send an error instead? Say someone is running queries, 
meanwhile another person drops a range. The first would see data disappear. 
Querying data outside of bounds could be considered a user error, and reported 
as such.


-- 
To view, visit http://gerrit.cloudera.org:8080/2772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e530eda60c00faf066c41b6bdb2b37f6d96a5dc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Binglin Chang <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to