Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2593
to look at the new patch set (#6).
Change subject: WIP: cache refactor and persistent support
......................................................................
WIP: cache refactor and persistent support
TODO:
- the tests run very slowly since they fsync thousands of times
- should split this back up into a refactor and the pmem support
- Seeing memory leak when running in persistent mode. It happens
when we do not have space in the cache to allocate for use and
we must allocate directly from the heap. The heap memory
does not get freed. I do not understand why.
What's fixed:
-Added test for verify persistent memory repopulation.
-Fixed comments, updated some code in nvm_cache.cc and
-renamed PopulateLRUHandle to InsertCacheHandle.
-Removed strlen code
-Fixed compile error in cfile-test.cc
Change-Id: Id72570ead662670bf42175756a18ae08d7cd0a07
---
M CMakeLists.txt
A cmake_modules/FindPmem.cmake
D cmake_modules/FindVmem.cmake
M src/kudu/cfile/block_cache-test.cc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/block_cache.h
M src/kudu/cfile/block_handle.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/codegen/code_cache.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/nvm_cache-test.cc
M src/kudu/util/nvm_cache.cc
M thirdparty/build-definitions.sh
17 files changed, 1,066 insertions(+), 494 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/2593/6
--
To view, visit http://gerrit.cloudera.org:8080/2593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id72570ead662670bf42175756a18ae08d7cd0a07
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sarah Jelinek <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sarah Jelinek <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
