Dan Burkert has posted comments on this change.

Change subject: Non-covering Range Partitions design doc
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/2772/5/docs/design-docs/non-covering-range-partitions.md
File docs/design-docs/non-covering-range-partitions.md:

Line 1: # Non-covering Range Partitions
> How are we going to test this?
I think our existing methods for testing table schema permutations will work 
well (i.e. tests like flex-partitioning-itest).


Line 176: ### Client-side Caching of Range Partition Non-existence
> Considering what's in the "Add Range Partition" section, this seems necessa
I've removed that section, since I think it only muddies the waters.


Line 180: handling non-existent range partitionss. In particular, every 
operation on a
> Nit: partitions
Done


Line 211: partition add.
> Nit: partition add --> partition to be added.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e530eda60c00faf066c41b6bdb2b37f6d96a5dc
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Binglin Chang <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to