Todd Lipcon has posted comments on this change. Change subject: KUDU-1410 (part 5): rpc: sample each RPC method in several latency buckets, expose on /rpcz ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/2798/6/src/kudu/rpc/rpc_introspection.proto File src/kudu/rpc/rpc_introspection.proto: Line 56: //------------------------------------------------------------ > Maybe some comments here for the messages and fields? Done http://gerrit.cloudera.org:8080/#/c/2798/6/src/kudu/rpc/rpcz_store.cc File src/kudu/rpc/rpcz_store.cc: Line 123: SampleBucket* bucket = &buckets_[kNumBuckets - 1];; > Nit: extra semicolon at the end here. Done Line 133: if (us_since_trace > kSampleIntervalMs) { oops, this should have been * 1000 here -- comparing micros and millis. That's what I get for cleaning up the code to extract a constant :) Line 155: sample_pb->set_trace(bucket.sample.trace->DumpToString(Trace::INCLUDE_TIME_DELTAS | > Not just Trace::INCLUDE_ALL? Done -- To view, visit http://gerrit.cloudera.org:8080/2798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eadb3f7035b5b156cb624ce50876876a5698b17 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
