Todd Lipcon has posted comments on this change. Change subject: KUDU-1377 (part 2): Add version 2 of protobuf container file ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2815/1/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: Line 372: RETURN_NOT_OK_PREPEND(ReadAndCompareChecksum(reader, file_size, &tmp_offset, { header }), > Yeah, it would be for performance reasons, on solid state or nvram where th yea I think given it's not perf critical here, err on the side of less code rather than less syscalls Sorry, Adar, I meant *fewer* syscalls. Journalism class. -- To view, visit http://gerrit.cloudera.org:8080/2815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I239c7b99a55a74a6a658ff418830c1f9be13eaa6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
