Adar Dembo has posted comments on this change. Change subject: Fix use-after free in accessing InboundCall's MethodInfo ......................................................................
Patch Set 1: > hm, I spose we could. did we ever determine if there was a perf > difference between the two? I don't think we bothered to look deeper than "use make_shared() to ensure the object and its ref count are allocated together". Do you suspect there are differences beyond that? -- To view, visit http://gerrit.cloudera.org:8080/2833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30304fe6bd2074578e5cfc09ee18ef616d43e687 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
