Todd Lipcon has posted comments on this change. Change subject: tracing: add a 'label' for child traces ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2888/1/src/kudu/util/memory/arena.h File src/kudu/util/memory/arena.h: Line 131: bool RelocateStringPiece(StringPiece* sp); > Why not use the same kind of contract as RelocateSlice(), where the source Done -- To view, visit http://gerrit.cloudera.org:8080/2888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b9a7655131c1013fea26e5bc87651b38ff1920f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
