Adar Dembo has posted comments on this change. Change subject: ubsan: use our own libstdcxx ......................................................................
Patch Set 1: (1 comment) IIRC, we worked around this very issue in calls to kudu_malloc_usable_size() on vectors. Each one is conditioned on the vector being non-empty. Would you mind removing the checks from these calls, now that they're no longer needed? http://gerrit.cloudera.org:8080/#/c/2904/1/CMakeLists.txt File CMakeLists.txt: Line 320: set(UBSAN_GCC_DIR "${CMAKE_SOURCE_DIR}/thirdparty/installed-deps/gcc") Can we avoid the copy of this fom L348-352? Perhaps consolidate behind a cmake function or macro? -- To view, visit http://gerrit.cloudera.org:8080/2904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54f49d808aeb97d93d247a46a93161a1634921de Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
