Adar Dembo has posted comments on this change. Change subject: rpc: improve error messages for overly long RPC responses ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2915/1/src/kudu/rpc/serialization.cc File src/kudu/rpc/serialization.cc: Line 57: LOG(WARNING) << "Serialized " << message.GetTypeName() Nit: Could you use strings::Substitute so the entire sentence is more clear? Line 60: << "Sending anyway, but peer may reject the data."; Given the change to transfer.cc, aren't we guaranteed that the peer will reject the message? Or does the wording here account for the case where two different peers may have different values for FLAGS_rpc_max_message_size? -- To view, visit http://gerrit.cloudera.org:8080/2915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id03f2e76d5929bfee33d3b2e4b55c74a97f95254 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
