Todd Lipcon has posted comments on this change. Change subject: rpc-bench: add async benchmark, make more configurable ......................................................................
Patch Set 2: (3 comments) Oops, yea I forgot to hit "post". Here are the old comments. http://gerrit.cloudera.org:8080/#/c/2937/2/src/kudu/rpc/rpc-bench.cc File src/kudu/rpc/rpc-bench.cc: Line 93: LOG(INFO) << "User CPU per req: " << user_cpu_micros_per_req << "us"; : LOG(INFO) << "Sys CPU per req: " << sys_cpu_micros_per_req << "us"; > Would it be helpful to indicate 'micros' in the log message, so it's clear it says "us" already, did you miss that? Line 215: TEST_F(RpcBench, BenchmarkCallAsync) { > Nit: maybe BenchmarkCallsAsync, so the singular/plural of the two tests agr Done Line 227: new ClientAsyncWorkload(this, messengers[i%threads]))); > Nit: i % threads Done -- To view, visit http://gerrit.cloudera.org:8080/2937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8318911ea76d85fa96acb52203101a97a539e42c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
