Adar Dembo has posted comments on this change. Change subject: Short-circuit CheckRowDeleted if there are no deletes in DeltaFile ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2975/1/src/kudu/tablet/deltafile.cc File src/kudu/tablet/deltafile.cc: Line 296: RETURN_NOT_OK(const_cast<DeltaFileReader*>(this)->InitOnce()); Shouldn't this be a call to Init(), not InitOnce()? Otherwise you won't get the once checking. -- To view, visit http://gerrit.cloudera.org:8080/2975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa35bab3f9a9fc82149d11821733e87a7aaf5e7a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
