Adar Dembo has posted comments on this change. Change subject: nvml: update to 1.0, add pmem, pmemobj libraries ......................................................................
Patch Set 2: (2 comments) I take it we need all three libraries for Kudu? http://gerrit.cloudera.org:8080/#/c/2956/2/cmake_modules/FindPmem.cmake File cmake_modules/FindPmem.cmake: Line 73: set(PMEM_ERR_MSG "Could not find the pmemobj library. Looked for headers") Nit: pmemobj or just pmem? Line 86: PMEMOBJ_DEPS Nit: move this down a couple lines so its with the rest of the PMEMOBJ variables? -- To view, visit http://gerrit.cloudera.org:8080/2956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I936be31f9df04ab8ac1a1a21d8804bc99ae50bb7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
