Adar Dembo has posted comments on this change. Change subject: KUDU-1434 Fixed web UI so BOOL is not printed as an unsupported type in generated Impala CREATE TABLE statements. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3001/1//COMMIT_MSG Commit Message: Line 7: KUDU-1434 : Fixed web UI so BOOL is not printed as an unsupported type in generated Impala CREATE TABLE statements. Nit: could you reformat this? Here's how we usually format our git commits: <80 char summary of fix, beginning with bug number> <empty line> <more text explaining fix in more detail, if necessary. Also wrapped to 80 chars> So here it'd be something like this: KUDU-1434: added BOOL type to Impala CREATE TABLE statements http://gerrit.cloudera.org:8080/#/c/3001/1/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: Line 111: *output << "BOOL"; I think it's actually supposed to BOOLEAN, not BOOL. Could you double check? -- To view, visit http://gerrit.cloudera.org:8080/3001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ea97a6261d5d1e39df70c7fa9a0ad8a8b823d99 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
