Adar Dembo has posted comments on this change. Change subject: thread: enable stack watchdog for thread creation ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3005/1//COMMIT_MSG Commit Message: Line 14: The only subtelty here is that starting the stack watchdog itself requires Nit: subtlety http://gerrit.cloudera.org:8080/#/c/3005/1/src/kudu/util/thread.cc File src/kudu/util/thread.cc: Line 505: SCOPED_WATCH_STACK((flags & NO_STACK_WATCHDOG) ? 0 : 250); Those warnings you saw were enough to identify the slowness as within pthread_create() though, right? Otherwise you're missing out on part of thread creation below. http://gerrit.cloudera.org:8080/#/c/3005/1/src/kudu/util/thread.h File src/kudu/util/thread.h: Line 119: NO_STACK_WATCHDOG = 1 << 0 Nit: add a comment explaining what this does? Line 138: BoundFunc f, uint64_t flags, Any particular reason why in this variant you're passing 'f' by value instead of by cref? Given that it's a template variable it doesn't seem safe to assume that it's always small enough to fit in registers. -- To view, visit http://gerrit.cloudera.org:8080/3005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia423084d01716e5d4884d17cdf836a43489a6ebc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
