Adar Dembo has posted comments on this change. Change subject: Add some more latency-related trace counters ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3008/1/src/kudu/util/trace-test.cc File src/kudu/util/trace-test.cc: Line 832: EXPECT_EQ("{\"foo\":10,\"bar\":10,\"baz\":499500}", > Remind me what that was? The map of trace metrics emitted is sorted, but the keys are pointers, not strings. So depending on what addresses the constants are placed, the order of map entries can vary, and isn't guaranteed to be based on alphabetically sorted keys. I saw this 100% of the time when I ran a fastdebug build locally, but not with regular debug builds. -- To view, visit http://gerrit.cloudera.org:8080/3008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie601e914c22b4ca86dc25f4be0c6ec5ef0e94404 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
