Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] fix ClassCastException: DeferredGroupException cannot be cast to ArrayList ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3020/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1492: // Notice that we do not handle the errback, if there's an exception it will come straight out. > My understanding: You got it, Adar. > Doesn't this mean that a failure in closeAllSessions() will cause us to skip > the disconnection and resource releasing phases of the shutdown? Is that safe? Yes it will skip, and it depends on your definition of safe. The client will be marked as closed and you won't be able to call it again. So it's not safe to use it again (javadoc above says to use a new client), and if the JVM isn't shutdown then some connections might stay alive, until they get hit the socket read timeout. I wasn't trying to solve that problem though, just the ClassCastException. -- To view, visit http://gerrit.cloudera.org:8080/3020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f3d084fae276c5dbbb46f36c43ad0d337f260a8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
