Mike Percy has posted comments on this change. Change subject: rpc: reduce the number of recv syscalls ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/2943/4/src/kudu/rpc/transfer.cc File src/kudu/rpc/transfer.cc: Line 79: buf_.resize(total_length_ + kMsgLengthPrefixLength); Add comment noting that this is for the next message? Line 135: } else { > If we're in here, 0 < extra < kMsgLengthPrefixLength, right? Maybe add DCHECK_LE(extra, kMsgLengthPrefixLength) http://gerrit.cloudera.org:8080/#/c/2943/4/src/kudu/rpc/transfer.h File src/kudu/rpc/transfer.h: Line 70: Status ReceiveBuffer(Socket &socket, gscoped_ptr<InboundTransfer>& next); > The pass-by-ref isn't google style guide friendly, but I imagine you're try seems worth it to change it to be style guide compliant -- To view, visit http://gerrit.cloudera.org:8080/2943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2adbe51b51267deb43b837c8ffae09cf8f54d251 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
