Todd Lipcon has posted comments on this change. Change subject: KUDU-1450. Avoid contention during LogBlockManager startup ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3042/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1422 > FWIW, I think I did this just for consistency. The compiler doesn't combine The compiler would combine it, but when i was reading the code, this made me wonder "hm, I wonder where else we are calling RemoveLogBlockUnlocked" and went searching for it, so thought it made more sense to just combine it -- To view, visit http://gerrit.cloudera.org:8080/3042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie680389e5e08dff89862ef32b652a9cc73f458f5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
