Adar Dembo has posted comments on this change. Change subject: Add an all-virtual ServerPicker class and a meta cache backed implementation ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3017/4/src/kudu/rpc/replicated_rpc.h File src/kudu/rpc/replicated_rpc.h: Line 45: class ReplicaPicker : public RefCountedThreadSafe<ReplicaPicker<Replica>> { > it's mean to be shared across rpc's (see follow up patches) so it makes sen I just found it odd that an interface (ReplicaPicker) stipulates that every implementation must inherit from RefCountedThreadSafe. If MetaCacheReplicaPicker needs to inherit, that's fine. But it wasn't immediately obvious to me why every implementation would. -- To view, visit http://gerrit.cloudera.org:8080/3017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id43db316606cb807ec0019c79b3bdf76fa509fe5 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
