Adar Dembo has posted comments on this change. Change subject: bootstrap: use the iterator interface to read the log ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3039/2//COMMIT_MSG Commit Message: Line 14: Before: : Time spent bootstrapping tablet: real 3.825s user 1.448s sys 1.000s : Time spent bootstrapping tablet: real 4.340s user 1.480s sys 0.988s : Time spent bootstrapping tablet: real 7.438s user 1.456s sys 1.080s : : After: : Time spent bootstrapping tablet: real 5.563s user 1.092s sys 1.172s : Time spent bootstrapping tablet: real 5.931s user 1.172s sys 0.976s : Time spent bootstrapping tablet: real 8.050s user 1.188s sys 1.192s I think you inserted your numbers backwards. I hope you did, anyway. :) http://gerrit.cloudera.org:8080/#/c/3039/2/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: Line 1057: if (s.ok()) { Isn't this guaranteed to be true? -- To view, visit http://gerrit.cloudera.org:8080/3039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31075a887d591071386c448d6e8769f92238bb07 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
