David Ribeiro Alves has posted comments on this change. Change subject: WIP: Integrate the request tracker with the client ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3080/1/src/kudu/rpc/retriable_rpc.h File src/kudu/rpc/retriable_rpc.h: Line 40: const scoped_refptr<RequestTracker>& request_tracker, > seeing that this has to get plumbed in here makes me wonder if we should ac makes sense, was just thinking that it might be useful to have around to be able to distinguish clients in the log (something akin to what we do for tablets and what not) and since a messenger isn't always immediately available it would make sense to keep it here. I'm ok to move it to the messenger if that doesn't make sense though -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
