Adar Dembo has posted comments on this change. Change subject: KUDU-1267 ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3085/1//COMMIT_MSG Commit Message: Line 7: KUDU-1267 Could you flesh this out some more? The JIRA number is a good start, but please add a sentence summarizing what this patch does. If you feel there needs to be further explanation, add a paragraph with more detail. http://gerrit.cloudera.org:8080/#/c/3085/1/java/kudu-client/src/main/java/org/kududb/client/RowResult.java File java/kudu-client/src/main/java/org/kududb/client/RowResult.java: Line 246: //Can't check type because this could be a long, string, or Timestamp So how does _removing_ this check address KUDU-1267? I don't understand. -- To view, visit http://gerrit.cloudera.org:8080/3085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I117f7f602926defd0271548b60e6abda1b592f26 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ted Malaska <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
